Notarise the macOS app #11119
Notarise the macOS app #11119
Conversation
if only to test it
...before we start the build process.
It doesn't work as a github dependency because the typescript doesn't get built.
| // We get the password from keychain. The keychain stores | ||
| // user IDs too, but apparently altool can't get the user ID | ||
| // from the keychain, so we need to get it from the environment. | ||
| const userId = process.env.NOTARIZE_APPLE_ID; |
There was a problem hiding this comment.
Who will set this env var? Can we manually extract it from keychain with keychain find-generic-password ... or similar?
There was a problem hiding this comment.
I was just going to put it in the ~/.profile on the build machine. I'd hoped we'd be be able to just get it out of the keychain but I can't work out how to get the entry in a place in the keychain where both altool and security can find it...
There was a problem hiding this comment.
Aha, I see... Well, probably it's fine. 😄
There was a problem hiding this comment.
What's the current method for getting this set up? I've tried NOTARIZE_CREDS=foo yarn build:electron:macos to no avail...
There was a problem hiding this comment.
Let's discuss this in #riot-dev.
|
(@dbkr can haz a title that will look okay in the changelog please?) |
Notarise the mac app in the electron build process